fix: use atomic writes for composed preset command files - #3974
Open
Quratulain-bilal wants to merge 3 commits into
Open
fix: use atomic writes for composed preset command files#3974Quratulain-bilal wants to merge 3 commits into
Quratulain-bilal wants to merge 3 commits into
Conversation
Three write_text() calls for composed command files were not atomic. A crash mid-write leaves a partial .md file which can cause errors when the command is later read. Now uses a shared _atomic_write_text helper with tempfile.mkstemp + os.replace.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds atomic writes for composed preset command files to prevent partial files after interrupted writes.
Changes:
- Adds a shared
_atomic_write_texthelper. - Uses it for all three composed-command write paths.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/presets/__init__.py |
Implements and adopts atomic composed-command writes. |
Review details
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
| try: | ||
| with os.fdopen(fd, "w", encoding="utf-8") as f: | ||
| f.write(content) | ||
| os.replace(tmp, path) |
mkstemp() creates files with mode 0600 (owner-only). The original write_text() used the default umask (typically 0644). Restore the expected permissions so other users/processes can read the file.
Use os.fchmod() to copy the destination file's permission bits to the staged temp file when the destination exists. Falls back to mkstemp's default 0600 when the destination is new.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three write_text() calls for composed command files were not atomic. A crash mid-write leaves a partial .md file which can cause errors when the command is later read.
Fix
Now uses a shared _atomic_write_text helper with empfile.mkstemp + os.replace.